Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4125#discussion_r122943463
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
 ---
    @@ -464,6 +464,14 @@ private void collectPartionableStates(
        private static void checkParallelismPreconditions(OperatorState 
operatorState, ExecutionJobVertex executionJobVertex) {
                //----------------------------------------max parallelism 
preconditions-------------------------------------
     
    +           if (operatorState.getMaxParallelism() < 
executionJobVertex.getParallelism()) {
    +                   throw new IllegalStateException("The state for task " + 
executionJobVertex.getJobVertexId() +
    +                           " can not be restored. The maximum parallelism 
" + operatorState.getMaxParallelism() +
    --- End diff --
    
    can you added braces around the (max)parallelism? The error message 
currently looks like this:
    
    ```
    Caused by: java.lang.IllegalStateException: The state for task 
adf090656b210b1609ad3203d4ee7329 can not be restored. The maximum parallelism 
128 of the restored state is lower than the configured parallelism 140. Please 
reduce the parallelism of the task to be lower or equal to the maximum 
parallelism.
    ```
    
    But i think
    ```
    Caused by: java.lang.IllegalStateException: The state for task 
adf090656b210b1609ad3203d4ee7329 can not be restored. The maximum parallelism 
(128) of the restored state is lower than the configured parallelism (140). 
Please reduce the parallelism of the task to be lower or equal to the maximum 
parallelism.
    ```
    looks nicer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to