[ https://issues.apache.org/jira/browse/FLINK-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055833#comment-16055833 ]
ASF GitHub Bot commented on FLINK-6938: --------------------------------------- Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r122978426 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -1164,16 +1186,16 @@ private void serializeStates(Set<State<T>> states, DataOutputView out) throws IO String trgt = nameSerializer.deserialize(in); StateTransitionAction action = actionSerializer.deserialize(in); - IterativeCondition<T> condition = null; try { - condition = deserializeCondition(in); + // backward compatibility + deserializeCondition(in); --- End diff -- Just a suggestion/question, why not create an alternative path here? > IterativeCondition should support RichFunction interface > -------------------------------------------------------- > > Key: FLINK-6938 > URL: https://issues.apache.org/jira/browse/FLINK-6938 > Project: Flink > Issue Type: Sub-task > Components: CEP > Reporter: Jark Wu > Assignee: Jark Wu > Fix For: 1.4.0 > > > In FLIP-20, we need IterativeCondition to support an {{open()}} method to > compile the generated code once. We do not want to insert a if condition in > the {{filter()}} method. So I suggest make IterativeCondition support > {{RichFunction}} interface. -- This message was sent by Atlassian JIRA (v6.4.14#64029)