[ https://issues.apache.org/jira/browse/FLINK-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057218#comment-16057218 ]
ASF GitHub Bot commented on FLINK-6938: --------------------------------------- Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r123192355 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -126,6 +129,7 @@ public AbstractKeyedCEPPatternOperator( this.isProcessingTime = Preconditions.checkNotNull(isProcessingTime); this.keySerializer = Preconditions.checkNotNull(keySerializer); this.nfaFactory = Preconditions.checkNotNull(nfaFactory); + this.conditionRegistry = nfaFactory.createNFA().getConditionRegistry(); --- End diff -- I am ok that `NFA` right now has pointer to `conditionRegistry`. The thing I meant is just in this line, as we call `createNFA()` and ignore the created `NFA`. The `nfaFactory` also has a pointer to the same `nfaRegistry` so instead of `nfaFactory.createNFA().getConditionRegistry()` we could call `nfaFactory.getConditionRegistry()`. What do you think? > IterativeCondition should support RichFunction interface > -------------------------------------------------------- > > Key: FLINK-6938 > URL: https://issues.apache.org/jira/browse/FLINK-6938 > Project: Flink > Issue Type: Sub-task > Components: CEP > Reporter: Jark Wu > Assignee: Jark Wu > Fix For: 1.4.0 > > > In FLIP-20, we need IterativeCondition to support an {{open()}} method to > compile the generated code once. We do not want to insert a if condition in > the {{filter()}} method. So I suggest make IterativeCondition support > {{RichFunction}} interface. -- This message was sent by Atlassian JIRA (v6.4.14#64029)