[
https://issues.apache.org/jira/browse/FLINK-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063284#comment-16063284
]
ASF GitHub Bot commented on FLINK-4286:
---------------------------------------
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3270#discussion_r124046763
--- Diff: flink-examples/flink-examples-streaming/pom.xml ---
@@ -482,54 +502,19 @@ under the License.
<copy
file="${project.basedir}/target/flink-examples-streaming_2.10-${project.version}-WindowJoin.jar"
tofile="${project.basedir}/target/WindowJoin.jar" />
<copy
file="${project.basedir}/target/flink-examples-streaming_2.10-${project.version}-WordCount.jar"
tofile="${project.basedir}/target/WordCount.jar" />
<copy
file="${project.basedir}/target/flink-examples-streaming_2.10-${project.version}-SocketWindowWordCount.jar"
tofile="${project.basedir}/target/SocketWindowWordCount.jar" />
+ <copy
file="${project.basedir}/target/flink-examples-streaming_2.10-${project.version}-Kafka09.jar"
tofile="${project.basedir}/target/Kafka09.jar" />
</target>
</configuration>
</execution>
</executions>
</plugin>
- <!-- Use the shade plugin to build a fat jar for the
kafka example -->
+ <!-- Use the shade plugin to build a fat jar for the
twitter example -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<executions>
<execution>
- <id>fat-jar-kafka-example</id>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- <configuration>
-
<shadeTestJar>false</shadeTestJar>
-
<shadedArtifactAttached>false</shadedArtifactAttached>
-
<createDependencyReducedPom>false</createDependencyReducedPom>
- <transformers>
- <transformer
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
-
<mainClass>org.apache.flink.streaming.examples.kafka.ReadFromKafka</mainClass>
- </transformer>
- </transformers>
-
<finalName>Kafka</finalName>
- <!--
<outputFile>Kafka.jar</outputFile> -->
- <filters>
- <filter>
-
<artifact>*</artifact>
-
<includes>
-
<include>org/apache/flink/streaming/examples/kafka/**</include>
-
<include>org/apache/flink/streaming/**</include>
-
<include>org/apache/kafka/**</include>
-
<include>org/apache/curator/**</include>
-
<include>org/apache/zookeeper/**</include>
-
<include>org/apache/jute/**</include>
-
<include>org/I0Itec/**</include>
-
<include>jline/**</include>
-
<include>com/yammer/**</include>
-
<include>kafka/**</include>
-
</includes>
- </filter>
- </filters>
- </configuration>
- </execution>
- <execution>
--- End diff --
What's the reasoning for deleting this section?
> Have Kafka examples that use the Kafka 0.9 connector
> ----------------------------------------------------
>
> Key: FLINK-4286
> URL: https://issues.apache.org/jira/browse/FLINK-4286
> Project: Flink
> Issue Type: Improvement
> Components: Examples
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Dmitrii Kniazev
> Priority: Minor
> Labels: starter
>
> The {{ReadFromKafka}} and {{WriteIntoKafka}} examples use the 0.8 connector,
> and the built example jar is named {{Kafka.jar}} under
> {{examples/streaming/}} in the distributed package.
> Since we have different connectors for different Kafka versions, it would be
> good to have examples for different versions, and package them as
> {{Kafka08.jar}} and {{Kafka09.jar}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
