Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4200#discussion_r124439791
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/datastream/DataStreamUserDefinedFunctionITCase.scala
---
@@ -230,6 +231,26 @@ class DataStreamUserDefinedFunctionITCase extends
StreamingMultipleProgramsTestB
assertEquals(expected.sorted, StreamITCase.testResults.sorted)
}
+
+ @Test
+ def testScalarFunctionDeterministic(): Unit = {
--- End diff --
Yes, agree with @wuchong , Add a test in `ExpressionReductionTest` is
correct. and I think it's better to add a exception test case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---