Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4200#discussion_r124457316
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
---
@@ -422,4 +423,50 @@ class ExpressionReductionTest extends TableTestBase {
util.verifyTable(result, expected)
}
+ @Test(expected = classOf[NullPointerException])
+ def testReduceDeterministicUDF(): Unit = {
--- End diff --
The exception isn't caused by Flink, to check an unexpected exception is
not a good way. I suggest to mark this test as `@Ignore` and add a TODO comment
on the top of the test. After CALCITE-1860 is fixed, we can reopen this test or
check&remove this test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
