[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066049#comment-16066049
]
ASF GitHub Bot commented on FLINK-6996:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r124466523
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer010.java
---
@@ -411,6 +414,18 @@ public void processElement(StreamRecord<T> element)
throws Exception {
invokeInternal(element.getValue(), element.getTimestamp());
}
+ @Override
+ public void snapshotState(FunctionSnapshotContext context) throws
Exception {
+ final FlinkKafkaProducerBase<T> internalProducer =
(FlinkKafkaProducerBase<T>) userFunction;
+ internalProducer.snapshotState(context);
+ }
+
+ @Override
+ public void initializeState(FunctionInitializationContext context)
throws Exception {
--- End diff --
nit: I would declare `initializeState` before `snapshotState`, just for the
sake of a better logic flow.
> FlinkKafkaProducer010 doesn't guarantee at-least-once semantic
> --------------------------------------------------------------
>
> Key: FLINK-6996
> URL: https://issues.apache.org/jira/browse/FLINK-6996
> Project: Flink
> Issue Type: Bug
> Components: Kafka Connector
> Affects Versions: 1.2.0, 1.3.0, 1.2.1, 1.3.1
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
>
> FlinkKafkaProducer010 doesn't implement CheckpointedFunction interface. This
> means, when it's used like a "regular sink function" (option a from [the java
> doc|https://ci.apache.org/projects/flink/flink-docs-master/api/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer010.html])
> it will not flush the data on "snapshotState" as it is supposed to.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
