[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066103#comment-16066103
]
ASF GitHub Bot commented on FLINK-6996:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r124476235
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
---
@@ -116,6 +120,30 @@ public String getVersion() {
}
@Override
+ public <K, V> Collection<ConsumerRecord<K, V>>
getAllRecordsFromTopic(Properties properties, String topic, int partition) {
+ ImmutableList.Builder<ConsumerRecord<K, V>> result =
ImmutableList.builder();
+ KafkaConsumer<K, V> consumer = new KafkaConsumer<>(properties);
+ consumer.assign(ImmutableList.of(new TopicPartition(topic,
partition)));
+
+ while (true) {
+ boolean processedAtLeastOneRecord = false;
--- End diff --
No, it's other way around. We are braking the loop if after pooling for 1
second for next records we did get an empty response. Added comment.
> FlinkKafkaProducer010 doesn't guarantee at-least-once semantic
> --------------------------------------------------------------
>
> Key: FLINK-6996
> URL: https://issues.apache.org/jira/browse/FLINK-6996
> Project: Flink
> Issue Type: Bug
> Components: Kafka Connector
> Affects Versions: 1.2.0, 1.3.0, 1.2.1, 1.3.1
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
>
> FlinkKafkaProducer010 doesn't implement CheckpointedFunction interface. This
> means, when it's used like a "regular sink function" (option a from [the java
> doc|https://ci.apache.org/projects/flink/flink-docs-master/api/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer010.html])
> it will not flush the data on "snapshotState" as it is supposed to.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
