Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4199#discussion_r124630671
  
    --- Diff: 
flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/fun/SqlGroupFunction.java
 ---
    @@ -50,7 +50,8 @@
      * GROUP BY HOP(rowtime, INTERVAL '1' HOUR), productId
      * </pre></blockquote>
      */
    -class SqlGroupFunction extends SqlFunction {
    +// FLINK QUICK FIX
    +public class SqlGroupFunction extends SqlFunction {
    --- End diff --
    
    Calcite 1.13 was released and we are planning to update the dependency. 
    I guess we cannot simply drop this file and use Calcite's version, if we 
start modifying the code. 
    
    Do we have plans to contribute the changes back or do we want to keep this 
file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to