Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4199#discussion_r125002758
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala
---
@@ -349,6 +350,14 @@ class RelTimeIndicatorConverter(rexBuilder:
RexBuilder) extends RelShuttle {
isTimeIndicatorType(updatedCall.getOperands.get(0).getType) =>
updatedCall
+ case BasicOperatorTable.TUMBLE_ROWTIME |
+ BasicOperatorTable.TUMBLE_PROCTIME |
+ BasicOperatorTable.HOP_ROWTIME |
+ BasicOperatorTable.HOP_PROCTIME |
+ BasicOperatorTable.SESSION_ROWTIME |
+ BasicOperatorTable.SESSION_PROCTIME if
isTimeIndicatorType(updatedCall.getType) =>
+ updatedCall
--- End diff --
I thought about this again, I think we have to use this approach. Because
the operands are always materialized, because of the shape of the relational
tree (groupings are always materialized which is correct).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
