[
https://issues.apache.org/jira/browse/FLINK-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070449#comment-16070449
]
ASF GitHub Bot commented on FLINK-6043:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3583#discussion_r125088693
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -1070,9 +1088,9 @@ public void suspend(Throwable suspensionCause) {
* exceptions that indicate a bug or an unexpected call race), and
where a full restart is the
* safe way to get consistency back.
*
- * @param t The exception that caused the failure.
+ * @param errorInfo ErrorInfo containing the exception that caused the
failure.
*/
- public void failGlobal(Throwable t) {
+ public void failGlobal(ErrorInfo errorInfo) {
--- End diff --
Why don't we do a null check for `errorInfo` similar to the one in
`suspend`? I think it should be fine to assume that this parameter is not null.
> Display time when exceptions/root cause of failure happened
> -----------------------------------------------------------
>
> Key: FLINK-6043
> URL: https://issues.apache.org/jira/browse/FLINK-6043
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Affects Versions: 1.3.0
> Reporter: Till Rohrmann
> Assignee: Chesnay Schepler
> Priority: Minor
>
> In order to better understand the behaviour of Flink jobs, it would be nice
> to add timestamp information to exception causing the job to restart or to
> fail. This information could then be displayed in the web UI making it easier
> for the user to understand what happened when.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
