[
https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572350#comment-14572350
]
ASF GitHub Bot commented on FLINK-2155:
---------------------------------------
GitHub user lokeshrajaram opened a pull request:
https://github.com/apache/flink/pull/776
[FLINK-2155] Enforce import restriction on usage of Flink shaded package
and Commons Validate
@rmetzger sorry I had issues squashing commits hence this new pull request.
Not sure if I am doing it right. Sorry for the trouble
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lokeshrajaram/flink checks_for_import
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/776.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #776
----
commit 733c704b094c2d7a19351e43d6338ccc774d02df
Author: Lokesh Rajaram <[email protected]>
Date: 2015-05-28T04:29:33Z
Merge pull request #1 from apache/master
update from original
commit 3b1c2eb8aa98f9176007f7e7a9cb3e973fdc4a02
Author: Lokesh Rajaram <[email protected]>
Date: 2015-06-03T06:22:12Z
getting latest
Merge branch 'master' of https://github.com/apache/flink
commit 9188d804e84a350848fed7d01c1a698d0bcfbaea
Author: Lokesh Rajaram <[email protected]>
Date: 2015-06-04T06:45:44Z
Merge branch 'master' of https://github.com/apache/flink
commit 3f07464ce937296c0409d561bf8548e5403c4346
Author: Lokesh Rajaram <[email protected]>
Date: 2015-06-04T08:13:27Z
[FLINK-2155] Enforce import restriction on usage of Flink shaded package
and Commons Validate
----
> Add an additional checkstyle validation for illegal imports
> -----------------------------------------------------------
>
> Key: FLINK-2155
> URL: https://issues.apache.org/jira/browse/FLINK-2155
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Reporter: Lokesh Rajaram
> Assignee: Lokesh Rajaram
>
> Add an additional check-style validation for illegal imports.
> To begin with the following two package import are marked as illegal:
> 1. org.apache.commons.lang3.Validate
> 2. org.apache.flink.shaded.*
> Implementation based on:
> http://checkstyle.sourceforge.net/config_imports.html#IllegalImport
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
