[ 
https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572392#comment-14572392
 ] 

ASF GitHub Bot commented on FLINK-2155:
---------------------------------------

Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/776#issuecomment-108791701
  
    Hey @lokeshrajaram. This is not right, but it's not a problem. We can 
easily fix it. :-) I suggest that you do the following:
    
    1. If you don't have the Flink repository as a remote, add it: `git add 
remote flink https://git-wip-us.apache.org/repos/asf/flink.git` and do a fetch 
`git fetch flink`. This depends on whether you cloned your fork or the main 
repo.
    
    2. Checkout a new branch from flink/master: `git checkout -b YOUR_BRANCH 
flink/master`.
    
    3. Cherry pick your commit: `git cherry-pick 3f07464`. This will add your 
commit to the new branch. There should be no conflicts.
    
    4. Now force push this to the branch of *this* pull request: `git push -f 
origin YOUR_BRANCH:checks_for_import`. Assuming that origin is your forked 
repository. You have to force push, because you are changing the history of 
this branch.


> Add an additional checkstyle validation for illegal imports
> -----------------------------------------------------------
>
>                 Key: FLINK-2155
>                 URL: https://issues.apache.org/jira/browse/FLINK-2155
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Lokesh Rajaram
>            Assignee: Lokesh Rajaram
>
> Add an additional check-style validation for illegal imports.
> To begin with the following two package import are marked as illegal:
>      1. org.apache.commons.lang3.Validate
>      2. org.apache.flink.shaded.*
> Implementation based on: 
> http://checkstyle.sourceforge.net/config_imports.html#IllegalImport



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to