[
https://issues.apache.org/jira/browse/FLINK-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071319#comment-16071319
]
ASF GitHub Bot commented on FLINK-6522:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4204#discussion_r125164998
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/filesystem/FileSystemStateStorageHelper.java
---
@@ -77,4 +83,18 @@ public FileSystemStateStorageHelper(Path rootPath,
String prefix) throws IOExcep
private Path getNewFilePath() {
return new Path(rootPath, FileUtils.getRandomFilename(prefix));
}
+
+ @Override
+ public void closeAndCleanupAllData() {
+ try {
+ fs.delete(rootPath, true);
--- End diff --
We cannot simply delete the rootPath, because it's
`HighAvailabilityOptions.HA_STORAGE_PATH`. Thus, we would also delete files
from other components in this directory (e.g. the `BlobServer`). I think the
`FileSystemStateStorageHelper` has to create a sub directory for the state to
store. That directory, we can easily delete.
> Add ZooKeeper cleanup logic to ZooKeeperHaServices
> --------------------------------------------------
>
> Key: FLINK-6522
> URL: https://issues.apache.org/jira/browse/FLINK-6522
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Till Rohrmann
> Assignee: Fang Yong
>
> The {{ZooKeeperHaServices}} provide a {{CuratorFramework}} client to access
> ZooKeeper data. Consequently, all data (also for different job) are stored
> under the same root node. When
> {{HighAvailabilityServices#closeAndCleanupAllData}} is called, then this data
> should be cleaned up. This cleanup logic is currently missing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
