[
https://issues.apache.org/jira/browse/FLINK-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071318#comment-16071318
]
ASF GitHub Bot commented on FLINK-6522:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4204#discussion_r125164958
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java
---
@@ -244,6 +244,7 @@ public static ZooKeeperLeaderElectionService
createLeaderElectionService(
* @return {@link ZooKeeperSubmittedJobGraphStore} instance
* @throws Exception if the submitted job graph store cannot be created
*/
+ @Deprecated
--- End diff --
Can we remove this method? If not, then at least write why this method was
deprecated using the `@deprecated` tag.
> Add ZooKeeper cleanup logic to ZooKeeperHaServices
> --------------------------------------------------
>
> Key: FLINK-6522
> URL: https://issues.apache.org/jira/browse/FLINK-6522
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Till Rohrmann
> Assignee: Fang Yong
>
> The {{ZooKeeperHaServices}} provide a {{CuratorFramework}} client to access
> ZooKeeper data. Consequently, all data (also for different job) are stored
> under the same root node. When
> {{HighAvailabilityServices#closeAndCleanupAllData}} is called, then this data
> should be cleaned up. This cleanup logic is currently missing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
