[ 
https://issues.apache.org/jira/browse/FLINK-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080449#comment-16080449
 ] 

ASF GitHub Bot commented on FLINK-6900:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4110#discussion_r126443494
  
    --- Diff: 
flink-metrics/flink-metrics-statsd/src/main/java/org/apache/flink/metrics/statsd/StatsDReporter.java
 ---
    @@ -193,7 +198,10 @@ private void send(final String name, final String 
value) {
        @Override
        public String filterCharacters(String input) {
                char[] chars = null;
    -           final int strLen = input.length();
    +           if (input.length() > maxComponentLength) {
    +                   log.warn("The metric name component {} exceeded the {} 
characters length limit and was truncated.", input, maxComponentLength);
    +           }
    +           final int strLen = Math.min(input.length(), maxComponentLength);
    --- End diff --
    
    same here about the `Math.min`


> Limit size of indiivual components in DropwizardReporter
> --------------------------------------------------------
>
>                 Key: FLINK-6900
>                 URL: https://issues.apache.org/jira/browse/FLINK-6900
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0, 1.3.2
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to