[
https://issues.apache.org/jira/browse/FLINK-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083898#comment-16083898
]
ASF GitHub Bot commented on FLINK-6900:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4110#discussion_r126940120
--- Diff:
flink-metrics/flink-metrics-statsd/src/test/java/org/apache/flink/metrics/statsd/StatsDReporterTest.java
---
@@ -60,6 +60,20 @@
public class StatsDReporterTest extends TestLogger {
@Test
+ public void testNameTruncating() {
+ StatsDReporter reporter = new StatsDReporter();
+
+ MetricConfig config = new MetricConfig();
+ config.setProperty(StatsDReporter.ARG_HOST, "localhost");
+ config.setProperty(StatsDReporter.ARG_PORT, "12345");
+ config.setProperty(StatsDReporter.ARG_MAX_COMPONENT_LENGTH,
"10");
+
+ reporter.open(config);
+
+ assertEquals("0123456789",
reporter.filterCharacters("0123456789DEADBEEF"));
--- End diff --
hmm, seems something was lost during the transfer :(
iirc, I wanted to ask whether it makes sense to also test that things like
`a.b.0123456789DEADBEEF.c` are properly truncated to `a.b.0123456789.c` for the
whole metric name
> Limit size of indiivual components in DropwizardReporter
> --------------------------------------------------------
>
> Key: FLINK-6900
> URL: https://issues.apache.org/jira/browse/FLINK-6900
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0, 1.3.2
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
