[
https://issues.apache.org/jira/browse/FLINK-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082374#comment-16082374
]
ASF GitHub Bot commented on FLINK-6964:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4192#discussion_r126721791
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStoreTest.java
---
@@ -160,9 +162,12 @@ public Void answer(InvocationOnMock invocation) throws
Throwable {
stateStorage,
Executors.directExecutor());
- SharedStateRegistry sharedStateRegistry = new
SharedStateRegistry();
+ SharedStateRegistry sharedStateRegistry = spy(new
SharedStateRegistry());
zooKeeperCompletedCheckpointStore.recover(sharedStateRegistry);
+ verify(retrievableStateHandle1.retrieveState(),
times(1)).registerSharedStatesAfterRestored(sharedStateRegistry);
--- End diff --
Was the bug in the zookeeper checkpoint store or the standalone checkpoint
store? Should there also be a test for the standalone checkpoint store to
verify that it works now?
> Fix recovery for incremental checkpoints in StandaloneCompletedCheckpointStore
> ------------------------------------------------------------------------------
>
> Key: FLINK-6964
> URL: https://issues.apache.org/jira/browse/FLINK-6964
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Blocker
> Fix For: 1.3.2
>
>
> {{StandaloneCompletedCheckpointStore}} does not register shared states ion
> resume. However, for externalized checkpoints, it register the checkpoint
> from which it resumed. This checkpoint gets added to the completed checkpoint
> store as part of resume.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
