[ 
https://issues.apache.org/jira/browse/FLINK-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085791#comment-16085791
 ] 

ASF GitHub Bot commented on FLINK-6964:
---------------------------------------

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4192
  
    This looks super nice now! I tried it and disabled each of the two fixes 
(registering shared state after restore and backend UUIDs) and reverting either 
made the new integration test fail.
    
    Let's give @StephanEwen some time to look over this as well but from my 
side this LGTM now.
    
    When merging, the changes to `SharedStateRegistry` and 
`ZooKeeperCompletedCheckpointStoreTest` should be factored out into a separate 
commit. They are good changes but unrelated to the Jira issue and bug that this 
fixes.


> Fix recovery for incremental checkpoints in StandaloneCompletedCheckpointStore
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-6964
>                 URL: https://issues.apache.org/jira/browse/FLINK-6964
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Blocker
>             Fix For: 1.3.2
>
>
> {{StandaloneCompletedCheckpointStore}} does not register shared states ion 
> resume. However, for externalized checkpoints, it register the checkpoint 
> from which it resumed. This checkpoint gets added to the completed checkpoint 
> store as part of resume.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to