Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4274#discussion_r126870614
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
 ---
    @@ -982,4 +982,27 @@ object randInteger {
       }
     }
     
    +/**
    +  * Returns the string that results from concatenating the arguments.
    +  * Returns NULL if any argument is NULL.
    +  */
    +object concat {
    +  def apply(strings: Expression*): Expression = {
    +    new Concat(strings)
    +  }
    +}
    +
    +/**
    +  * Returns the string that results from concatenating the arguments and 
separator.
    +  * Returns NULL If the separator is NULL.
    +  *
    +  * Note: this user-defined function does not skip empty strings. However, 
it does skip any NULL
    +  * values after the separator argument.
    +  **/
    +object concat_ws {
    +  def apply(separator: Expression, strings: Expression*): Expression = {
    --- End diff --
    
    I would suggest to change this signature to `apply(separator: Expression, 
first: Expression, second: Expression, rest: Expression*)` to avoid misusage 
such as `concat_ws(",")`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to