[ https://issues.apache.org/jira/browse/FLINK-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083655#comment-16083655 ]
ASF GitHub Bot commented on FLINK-6975: --------------------------------------- Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4274#discussion_r126896677 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/validate/FunctionCatalog.scala --- @@ -107,6 +107,18 @@ class FunctionCatalog { val function = aggregateFunction.getFunction AggFunctionCall(function, children) + // concat_ws + case concat_ws if classOf[ConcatWs].isAssignableFrom(concat_ws) => --- End diff -- I'm not sure whether this is a good way. I prefer to add an additional try (for constructor `classOf[Expression], classOf[Seq[_]]`) in general expression construction. > Add CONCAT/CONCAT_WS supported in TableAPI > ------------------------------------------ > > Key: FLINK-6975 > URL: https://issues.apache.org/jira/browse/FLINK-6975 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL > Affects Versions: 1.4.0 > Reporter: sunjincheng > Assignee: sunjincheng > Labels: starter > > See FLINK-6925 for detail. -- This message was sent by Atlassian JIRA (v6.4.14#64029)