Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4192#discussion_r127453095
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/state/IncrementalKeyedStateHandleTest.java
 ---
    @@ -187,7 +188,7 @@ public void testSharedStateDeRegistration() throws 
Exception {
     
        private static IncrementalKeyedStateHandle create(Random rnd) {
                return new IncrementalKeyedStateHandle(
    -                   "test",
    +                   UUID.nameUUIDFromBytes("test".getBytes()),
    --- End diff --
    
    Let's set the right example for everyone that "learns by reading" other 
code.
    Also, we have seen cases where tests were unstable when executed on an 
Italian Laptop because of different default locales and charsets ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to