Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4192#discussion_r126721791
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStoreTest.java
---
@@ -160,9 +162,12 @@ public Void answer(InvocationOnMock invocation) throws
Throwable {
stateStorage,
Executors.directExecutor());
- SharedStateRegistry sharedStateRegistry = new
SharedStateRegistry();
+ SharedStateRegistry sharedStateRegistry = spy(new
SharedStateRegistry());
zooKeeperCompletedCheckpointStore.recover(sharedStateRegistry);
+ verify(retrievableStateHandle1.retrieveState(),
times(1)).registerSharedStatesAfterRestored(sharedStateRegistry);
--- End diff --
Was the bug in the zookeeper checkpoint store or the standalone checkpoint
store? Should there also be a test for the standalone checkpoint store to
verify that it works now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
