Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4343#discussion_r127579802
--- Diff: tools/maven/suppressions-java.xml ---
@@ -24,6 +24,9 @@ under the License.
<suppressions>
<suppress
- files=".*"
-
checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
+ files="ExecutionEnvironment\.java"
+ checks="JavadocParagraph"/>
+ <suppress
--- End diff --
In NestedMethodAnalyzer:358-362, there is an intentional fall through which
I would require a bit bigger refactoring to eliminate.
For the ExecutionEnvironment it was because we linked in javadoc to class
from a package that flink-java does not depend on. I've checked the generated
docs, and the links do not work nevertheless, so I removed the suppression and
changed `{@link` to `{@code`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
