[
https://issues.apache.org/jira/browse/FLINK-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092772#comment-16092772
]
ASF GitHub Bot commented on FLINK-7174:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4321#discussion_r128181037
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThreadTest.java
---
@@ -744,17 +745,21 @@ void
reassignPartitions(List<KafkaTopicPartitionState<TopicPartition>> newPartit
final OneShotLatch continueAssignmentLatch) {
final KafkaConsumer<byte[], byte[]> mockConsumer =
mock(KafkaConsumer.class);
+ final AtomicInteger callCounter = new AtomicInteger();
+
when(mockConsumer.assignment()).thenAnswer(new Answer<Object>()
{
@Override
public Object answer(InvocationOnMock invocationOnMock)
throws Throwable {
- if (midAssignmentLatch != null) {
- midAssignmentLatch.trigger();
- }
+ // first call is not the one that we want to
catch... we all love mocks, don't we?
--- End diff --
Could you explain a bit on "first call is not the one that we want to
catch"? Which test was failing? I have the feeling that this could have been
fixed in a different way.
> Bump dependency of Kafka 0.10.x to the latest one
> -------------------------------------------------
>
> Key: FLINK-7174
> URL: https://issues.apache.org/jira/browse/FLINK-7174
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
>
> We are using pretty old Kafka version for 0.10. Besides any bug fixes and
> improvements that were made between 0.10.0.1 and 0.10.2.1, it 0.10.2.1
> version is more similar to 0.11.0.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
