[
https://issues.apache.org/jira/browse/FLINK-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092769#comment-16092769
]
ASF GitHub Bot commented on FLINK-7174:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4321#discussion_r128180555
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@ -335,6 +356,9 @@ public void setOffsetsToCommit(Map<TopicPartition,
OffsetAndMetadata> offsetsToC
*/
@VisibleForTesting
void reassignPartitions(List<KafkaTopicPartitionState<TopicPartition>>
newPartitions) throws Exception {
+ if (newPartitions.size() > 0) {
+ hasAssignedPartitions = true;
+ }
--- End diff --
Should we actually extend this `if` block to wrap the whole code in
`reassignPartitions`? I.e., we shouldn't be doing the reassignment logic if
`newPartitions.size() == 0`.
> Bump dependency of Kafka 0.10.x to the latest one
> -------------------------------------------------
>
> Key: FLINK-7174
> URL: https://issues.apache.org/jira/browse/FLINK-7174
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
>
> We are using pretty old Kafka version for 0.10. Besides any bug fixes and
> improvements that were made between 0.10.0.1 and 0.10.2.1, it 0.10.2.1
> version is more similar to 0.11.0.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
