Github user stevenzwu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4357#discussion_r128642186
  
    --- Diff: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
 ---
    @@ -517,16 +519,13 @@ public void 
initializeState(FunctionInitializationContext context) throws Except
                                        LOG.debug("Using the following offsets: 
{}", restoredState);
                                }
                        }
    -                   if (restoredState != null && restoredState.isEmpty()) {
    -                           restoredState = null;
    -                   }
                } else {
                        LOG.info("No restore state for FlinkKafkaConsumer.");
                }
        }
     
        @Override
    -   public void snapshotState(FunctionSnapshotContext context) throws 
Exception {
    +   public final void snapshotState(FunctionSnapshotContext context) throws 
Exception {
    --- End diff --
    
    @tzulitai looks like the behavior was changed/fix in 1.3. Here is the 
Kafka09Fetcher.java code from 1.2 that was causing the behavior I described 
earlier.
    
    {code}
                // if checkpointing is enabled, we are not automatically 
committing to Kafka.
                kafkaProperties.setProperty(
                                ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG,
                                Boolean.toString(!enableCheckpointing));
    {code}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to