Github user stevenzwu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4357#discussion_r128642917
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -517,16 +519,13 @@ public void
initializeState(FunctionInitializationContext context) throws Except
LOG.debug("Using the following offsets:
{}", restoredState);
}
}
- if (restoredState != null && restoredState.isEmpty()) {
- restoredState = null;
- }
} else {
LOG.info("No restore state for FlinkKafkaConsumer.");
}
}
@Override
- public void snapshotState(FunctionSnapshotContext context) throws
Exception {
+ public final void snapshotState(FunctionSnapshotContext context) throws
Exception {
--- End diff --
```
the verrsion-specific implementations for FlinkKafkaConsumerBase may
override that and have incorrect implementations, where as our tests would
never realize it.
```
@tzulitai why would this be a concern for FlinkKafkaConsumerBase. if
version-specific implementations have bugs, they should have test to catch and
prevent bugs. We do need the capability to override the snapshot method to
no-op. what would be your suggested alternative?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
