[
https://issues.apache.org/jira/browse/FLINK-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099804#comment-16099804
]
ASF GitHub Bot commented on FLINK-7226:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4392
[FLINK-7226] [webUI] Properly include UTF-8 in content-type header
This PR corrects the `content-encoding` header introduced in FLINK-5705. As
documented
[here](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding)
this header is used to denote how the content is compressed (for example, with
gzip or deflate).
That the strings are encoded using `UTF-8` should be documented in the
`content-type` header instead, using the `charset` parameter, as documented
[here](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type).
There was also a bug in `TestBaseUtils#getFromHTTP`, where the UTF-8
charset was retrieved from the `content-encoding` header.
I've added tests to make sure we don't break this _again_.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7226
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4392.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4392
----
commit 3093d53f6f07afcc351b99a39586463fb0a0b83e
Author: zentol <[email protected]>
Date: 2017-07-19T11:51:35Z
[FLINK-7226] [webUI] Properly include UTF-8 in content-type header
----
> REST responses contain invalid content-encoding header
> ------------------------------------------------------
>
> Key: FLINK-7226
> URL: https://issues.apache.org/jira/browse/FLINK-7226
> Project: Flink
> Issue Type: Bug
> Components: Webfrontend
> Affects Versions: 1.2.0, 1.1.4, 1.3.1, 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0, 1.3.2
>
>
> FLINK-5705 made changes to the {{RuntimeMonitorHandler}} to set the
> {{content-encoding}} header to {{UTF-8}}. This however isn't a valid value
> for this header, and should instead be included in the {{content-type}}
> header.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
