Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4353#discussion_r129274874
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointStateRestoreTest.java
 ---
    @@ -118,10 +118,22 @@ public void testSetState() {
                        PendingCheckpoint pending = 
coord.getPendingCheckpoints().values().iterator().next();
                        final long checkpointId = pending.getCheckpointId();
     
    -                   SubtaskState checkpointStateHandles = new 
SubtaskState(serializedState, null, null, serializedKeyGroupStates, null);
    -                   coord.receiveAcknowledgeMessage(new 
AcknowledgeCheckpoint(jid, statefulExec1.getAttemptId(), checkpointId, new 
CheckpointMetrics(), checkpointStateHandles));
    -                   coord.receiveAcknowledgeMessage(new 
AcknowledgeCheckpoint(jid, statefulExec2.getAttemptId(), checkpointId, new 
CheckpointMetrics(), checkpointStateHandles));
    -                   coord.receiveAcknowledgeMessage(new 
AcknowledgeCheckpoint(jid, statefulExec3.getAttemptId(), checkpointId, new 
CheckpointMetrics(), checkpointStateHandles));
    +                   final TaskStateSnapshot subtaskStates = new 
TaskStateSnapshot();
    +
    +                   subtaskStates.putSubtaskStateByOperatorID(
    +                           OperatorID.fromJobVertexID(statefulId),
    +                           new OperatorSubtaskState(
    +                                   serializedState.get(0),
    +                                   
Collections.<OperatorStateHandle>emptyList(),
    +                                   
Collections.<OperatorStateHandle>emptyList(),
    +                                   
Collections.singletonList(serializedKeyGroupStates),
    +                                   
Collections.<KeyedStateHandle>emptyList()));
    +
    +                   //SubtaskState checkpointStateHandles = new 
SubtaskState(serializedState, null, null, serializedKeyGroupStates, null);
    --- End diff --
    
    whats up with this line?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to