Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4353#discussion_r129532719
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
---
@@ -208,13 +208,13 @@ public MetricGroup getMetricGroup() {
}
@Override
- public final void initializeState(OperatorStateHandles stateHandles)
throws Exception {
+ public final void initializeState(OperatorSubtaskState stateHandles)
throws Exception {
Collection<KeyedStateHandle> keyedStateHandlesRaw = null;
Collection<OperatorStateHandle> operatorStateHandlesRaw = null;
Collection<OperatorStateHandle> operatorStateHandlesBackend =
null;
- boolean restoring = null != stateHandles;
+ boolean restoring = (null != stateHandles);
--- End diff --
I like to do this when generating a boolean out of a `!=` or `==`
comparison because I find this easier to read in the presence of more than one
`=` character.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
