Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129774051
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -163,23 +161,17 @@ public AbstractYarnClusterDescriptor() {
}
}
- // tries to load the config through the environment, if it
fails it can still be set through the setters
- try {
- this.configurationDirectory =
CliFrontend.getConfigurationDirectoryFromEnv();
- this.flinkConfiguration =
GlobalConfiguration.loadConfiguration(configurationDirectory);
+ this.flinkConfiguration =
Preconditions.checkNotNull(flinkConfiguration);
+ userJarInclusion = getUserJarInclusionMode(flinkConfiguration);
- File confFile = new File(configurationDirectory +
File.separator + GlobalConfiguration.FLINK_CONF_FILENAME);
- if (!confFile.exists()) {
- throw new RuntimeException("Unable to locate
configuration file in " + confFile);
- }
- flinkConfigurationPath = new
Path(confFile.getAbsolutePath());
+ this.configurationDirectory =
Preconditions.checkNotNull(configurationDirectory);
+ // tries to load the config through the environment, if it
fails it can still be set through the setters
--- End diff --
is this comment still accurate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
