Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4280#discussion_r129771505
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
    @@ -478,12 +485,15 @@ public static void 
runInteractiveCli(YarnClusterClient yarnCluster, boolean read
     
        public static void main(final String[] args) throws Exception {
                final FlinkYarnSessionCli cli = new FlinkYarnSessionCli("", 
""); // no prefix for the YARN session
    -           Configuration flinkConfiguration = 
GlobalConfiguration.loadConfiguration();
    +
    +           final String configurationDirectory = 
CliFrontend.getConfigurationDirectoryFromEnv();
    --- End diff --
    
    Shouldn't the directory come from `args` with a default value taken from 
`env`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to