Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4280#discussion_r129877902
  
    --- Diff: 
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ---
    @@ -549,7 +559,12 @@ protected void runWithArgs(String[] args, String 
terminateAfterString, String[]
                final int startTimeoutSeconds = 180;
                final long deadline = System.currentTimeMillis() + 
(startTimeoutSeconds * 1000);
     
    -           Runner runner = new Runner(args, type, expectedReturnValue);
    +           Runner runner = new Runner(
    +                   args,
    +                   flinkConfiguration,
    +                   CliFrontend.getConfigurationDirectoryFromEnv(),
    --- End diff --
    
    Since the configuration directory is only required for the session case in 
`Runner`, the same argument applies as above. I agree that the 
`FlinkYarnSessionCli` should have a configurable configuration directory which 
can be controlled by a command line option.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to