[
https://issues.apache.org/jira/browse/FLINK-7125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103378#comment-16103378
]
ASF GitHub Bot commented on FLINK-7125:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129881025
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -478,12 +485,15 @@ public static void
runInteractiveCli(YarnClusterClient yarnCluster, boolean read
public static void main(final String[] args) throws Exception {
final FlinkYarnSessionCli cli = new FlinkYarnSessionCli("",
""); // no prefix for the YARN session
- Configuration flinkConfiguration =
GlobalConfiguration.loadConfiguration();
+
+ final String configurationDirectory =
CliFrontend.getConfigurationDirectoryFromEnv();
--- End diff --
Maybe it should? It is kind of strange that part of the configuration is
passed through `args` and some through `env`. I have never used this cli so
maybe I have wrong feeling about it :)
> Remove configuration loading from AbstractYarnClusterDescriptor
> ---------------------------------------------------------------
>
> Key: FLINK-7125
> URL: https://issues.apache.org/jira/browse/FLINK-7125
> Project: Flink
> Issue Type: Improvement
> Components: YARN
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> We should remove the explicit configuration loading from the
> {{AbstractYarnClusterDescriptor}} and instead pass it to the class via the
> constructor. This passed in configuration should then be sent to the
> application master when being started. That way, we can easily configure the
> started Yarn cluster.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
