[
https://issues.apache.org/jira/browse/FLINK-7125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103369#comment-16103369
]
ASF GitHub Bot commented on FLINK-7125:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129879671
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
---
@@ -210,6 +207,7 @@ public void testSetupApplicationMasterContainer() {
.getCommands().get(0));
// logback + log4j, with/out krb5, different JVM opts
+ // IMPORTANT: Beaware that we are using side effects here to
modify the created YarnClusterDescriptor
--- End diff --
We keep a reference on the `Configuration` object being held by the
`ClusterDescriptor`. Thus, the different settings for the different assert
statement end up in the same configuration instance. I'll add this to the
comment.
> Remove configuration loading from AbstractYarnClusterDescriptor
> ---------------------------------------------------------------
>
> Key: FLINK-7125
> URL: https://issues.apache.org/jira/browse/FLINK-7125
> Project: Flink
> Issue Type: Improvement
> Components: YARN
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> We should remove the explicit configuration loading from the
> {{AbstractYarnClusterDescriptor}} and instead pass it to the class via the
> constructor. This passed in configuration should then be sent to the
> application master when being started. That way, we can easily configure the
> started Yarn cluster.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
