Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r130058545
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@ -482,6 +501,12 @@ public void onComplete(Map<TopicPartition,
OffsetAndMetadata> offsets, Exception
if (ex != null) {
log.warn("Committing offsets to Kafka failed.
This does not compromise Flink's checkpoints.", ex);
+ if (callerCommitCallback != null) {
+ callerCommitCallback.onException(ex);
+ }
+ }
+ else if (callerCommitCallback != null) {
--- End diff --
See my comment above. Would like to remove these null checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
