[
https://issues.apache.org/jira/browse/FLINK-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107145#comment-16107145
]
ASF GitHub Bot commented on FLINK-7305:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4425
[FLINK-7305] [checkstyle] Allow imports from org.apache.flink.shaded and
add new import block
## What is the purpose of the change
This PR allows shaded imports which is hard requirement for the integration
of flink-shaded, and adds a separate checkstyle import block to distinguish
these from actual flink imports.
## Brief change log
- allow shaded imports from org.apache.flink.shaded
- add new import block for shaded imports
## Verifying this change
This change can be verified by
* importing some class from org.apache.flink.shaded (doesn't have to exist)
* run `mvn checkstyle:check`, it should only raise an `UnusedImport` error.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (**no**)
- The serializers: (**no**)
- The runtime per-record code paths (performance sensitive): (**no**)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**no**)
## Documentation
- Does this pull request introduce a new feature? (**no**)
- If yes, how is the feature documented? (**not applicable**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7305
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4425.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4425
----
commit 8bfb837f39617e84e37c3ecda4ea0e1b2ec0f196
Author: zentol <[email protected]>
Date: 2017-06-13T15:02:03Z
[FLINK-7305] [checkstyle] Allow imports from org.apache.flink.shaded + add
new import block
----
> Add new import block for shaded dependencies
> --------------------------------------------
>
> Key: FLINK-7305
> URL: https://issues.apache.org/jira/browse/FLINK-7305
> Project: Flink
> Issue Type: Sub-task
> Components: Checkstyle
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> Since we will start working against shaded namespaces I propose a new import
> block for these, to differentiate them from "original" flink imports.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
