[
https://issues.apache.org/jira/browse/FLINK-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110616#comment-16110616
]
ASF GitHub Bot commented on FLINK-7305:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4425#discussion_r130827731
--- Diff: tools/maven/checkstyle.xml ---
@@ -198,7 +198,7 @@ This file is based on the checkstyle file of Apache
Beam.
<!-- Checks for out of order import statements. -->
<property name="severity" value="error"/>
<!-- Flink imports first, then other imports, then javax, java and
scala imports, then static imports. -->
--- End diff --
nit: Update this comment line as well?
"Flink and Flink shaded imports first, then other ..."
> Add new import block for shaded dependencies
> --------------------------------------------
>
> Key: FLINK-7305
> URL: https://issues.apache.org/jira/browse/FLINK-7305
> Project: Flink
> Issue Type: Sub-task
> Components: Checkstyle
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> Since we will start working against shaded namespaces I propose a new import
> block for these, to differentiate them from "original" flink imports.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
