[
https://issues.apache.org/jira/browse/FLINK-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110720#comment-16110720
]
ASF GitHub Bot commented on FLINK-7348:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4458
Thanks for picking this up quickly.
I assume there is no way to make this only about `final` modifiers?
We could also approach this by doing selective exclusions of classes (like
the Memory Segments) where the rule fires, but we want to retain the
identifiers. There should not be too many, final methods in final classes are a
very selective thing...
> Allow redundant modifiers on methods
> ------------------------------------
>
> Key: FLINK-7348
> URL: https://issues.apache.org/jira/browse/FLINK-7348
> Project: Flink
> Issue Type: Improvement
> Components: Checkstyle
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> As per the discussion in https://github.com/apache/flink/pull/4447 we should
> allow redundant modifiers on methods, and revert changes that removed
> {{final}} modifiers from methods.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
