[
https://issues.apache.org/jira/browse/FLINK-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110738#comment-16110738
]
ASF GitHub Bot commented on FLINK-7348:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4458
We can't do it just for final modifiers unfortunately. We _could_ look into
creating a custom checkstyle rule based on
`https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/modifier/RedundantModifierCheck.java`
with minor modifications.
This should be rather straight-forward.
That said, i think that it is unlikely that these modifiers would be
removed by some auto-formatting, so they will neither clutter up diffs nor
cause any functional problems (because well, they're _redundant_ after all). We
could just keep them...
> Allow redundant modifiers on methods
> ------------------------------------
>
> Key: FLINK-7348
> URL: https://issues.apache.org/jira/browse/FLINK-7348
> Project: Flink
> Issue Type: Improvement
> Components: Checkstyle
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> As per the discussion in https://github.com/apache/flink/pull/4447 we should
> allow redundant modifiers on methods, and revert changes that removed
> {{final}} modifiers from methods.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
