Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4404#discussion_r130859046
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala
 ---
    @@ -260,4 +260,108 @@ class SetOperatorsITCase(
         val results = result.toDataSet[Row].collect()
         TestBaseUtils.compareResultAsText(results.asJava, expected)
       }
    +
    +  @Test
    +  def testInWithFilter(): Unit = {
    --- End diff --
    
    Should we validate the feature with plan tests (`TableTestBase`) rather 
than runtime tests? 
    The feature does not require new operators, just expressions which are 
tested by dedicated tests and joins which are also tested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to