[
https://issues.apache.org/jira/browse/FLINK-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111007#comment-16111007
]
ASF GitHub Bot commented on FLINK-7354:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4464
[FLINK-7354][tests] ignore "initialSeedUniquifierGenerator" thread in
thread list
## What is the purpose of the change
Netty may spawn a thread in its `ThreadLocalRandom` because of some secure
random use which may be caught in our `LocalFlinkMiniClusterITCase` thread
check as being started but not stopped by us. We can simply ignore this thread
and solve the test instability.
Alternatively, we could solve this similarly to
https://issues.apache.org/jira/browse/SOLR-10098 by setting
`ThreadLocalRandom.setInitialSeedUniquifier(1L);` but that may be less future
proof or even remove some randomness.
## Brief change log
- ignore any spawned thread with prefix `"initialSeedUniquifierGenerator"`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7354
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4464.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4464
----
commit 4a26f37bbffa70e848bc0fdd80b91d5c601b4ce6
Author: Nico Kruber <[email protected]>
Date: 2017-08-02T14:20:02Z
[FLINK-7354][tests] ignore "initialSeedUniquifierGenerator" thread in
thread list
Netty may spawn a thread in its ThreadLocalRandom class because of some
secure
random use which may be caught in our LocalFlinkMiniClusterITCase as not
being
stopped. Let's tolerate this.
Alternatively, we could solve this similarly to
https://issues.apache.org/jira/browse/SOLR-10098 by setting
ThreadLocalRandom.setInitialSeedUniquifier(1L);
but that may be less future proof or even remove some randomness.
----
> test instability in
> LocalFlinkMiniClusterITCase#testLocalFlinkMiniClusterWithMultipleTaskManagers
> -------------------------------------------------------------------------------------------------
>
> Key: FLINK-7354
> URL: https://issues.apache.org/jira/browse/FLINK-7354
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.1.4, 1.2.1, 1.4.0, 1.3.2
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Critical
>
> During {{mvn clean install}} on the 1.3.2 RC2, I found an inconsistently
> failing test at
> {{LocalFlinkMiniClusterITCase#testLocalFlinkMiniClusterWithMultipleTaskManagers}}:
> {code}
> testLocalFlinkMiniClusterWithMultipleTaskManagers(org.apache.flink.test.runtime.minicluster.LocalFlinkMiniClusterITCase)
> Time elapsed: 34.978 sec <<< FAILURE!
> java.lang.AssertionError: Thread
> Thread[initialSeedUniquifierGenerator,5,main] was started by the mini
> cluster, but not shut down
> at org.junit.Assert.fail(Assert.java:88)
> at
> org.apache.flink.test.runtime.minicluster.LocalFlinkMiniClusterITCase.testLocalFlinkMiniClusterWithMultipleTaskManagers(LocalFlinkMiniClusterITCase.java:168)
> {code}
> Searching the web for that error yields one previous thread on the dev-list,
> so this seems to be valid for quite old versions of flink, too, but
> apparently, was never solved:
> https://lists.apache.org/thread.html/07ce439bf6d358bd3139541b52ef6b8e8af249a27e09ae10b6698f81@%3Cdev.flink.apache.org%3E
> Test environment: Debian 9, openjdk 1.8.0_141-8u141-b15-1~deb9u1-b15
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
