[ 
https://issues.apache.org/jira/browse/FLINK-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116464#comment-16116464
 ] 

ASF GitHub Bot commented on FLINK-7354:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4464#discussion_r131633276
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/runtime/minicluster/LocalFlinkMiniClusterITCase.java
 ---
    @@ -49,7 +49,7 @@
      */
     public class LocalFlinkMiniClusterITCase extends TestLogger {
     
    -   private static final String[] ALLOWED_THREAD_PREFIXES = { };
    +   private static final String[] ALLOWED_THREAD_PREFIXES = { 
"initialSeedUniquifierGenerator" };
    --- End diff --
    
    Please format it as follows:
    ```
    private static final String[] ALLOWED_THREAD_PREFIXES = { 
        // ENTER_YOUR_COMMENT_HERE
        "initialSeedUniquifierGenerator" 
    };
    ```
    and add some comment describing what is an issue with this thread (that it 
is background/daemon thread and it sometimes is spawned before this test and 
sometimes it is spawned during this test)


> test instability in 
> LocalFlinkMiniClusterITCase#testLocalFlinkMiniClusterWithMultipleTaskManagers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-7354
>                 URL: https://issues.apache.org/jira/browse/FLINK-7354
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.1.4, 1.2.1, 1.4.0, 1.3.2
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Critical
>              Labels: test-stability
>
> During {{mvn clean install}} on the 1.3.2 RC2, I found an inconsistently 
> failing test at 
> {{LocalFlinkMiniClusterITCase#testLocalFlinkMiniClusterWithMultipleTaskManagers}}:
> {code}
> testLocalFlinkMiniClusterWithMultipleTaskManagers(org.apache.flink.test.runtime.minicluster.LocalFlinkMiniClusterITCase)
>   Time elapsed: 34.978 sec  <<< FAILURE!
> java.lang.AssertionError: Thread 
> Thread[initialSeedUniquifierGenerator,5,main] was started by the mini 
> cluster, but not shut down
>         at org.junit.Assert.fail(Assert.java:88)
>         at 
> org.apache.flink.test.runtime.minicluster.LocalFlinkMiniClusterITCase.testLocalFlinkMiniClusterWithMultipleTaskManagers(LocalFlinkMiniClusterITCase.java:168)
> {code}
> Searching the web for that error yields one previous thread on the dev-list, 
> so this seems to be valid for quite old versions of flink, too, but 
> apparently, was never solved:
> https://lists.apache.org/thread.html/07ce439bf6d358bd3139541b52ef6b8e8af249a27e09ae10b6698f81@%3Cdev.flink.apache.org%3E
> Test environment: Debian 9, openjdk 1.8.0_141-8u141-b15-1~deb9u1-b15



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to