GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4484
Client clean code
## What is the purpose of the change
Keeping code clean.
## Brief change log
- Move the `args` field to the `CommandLineOptions`(parent class)
- Clean up the test classes in `flink-clients` module
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? ( no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink client_clean_code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4484.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4484
----
commit 12c04abee88a2251a4bf69115e90100374546489
Author: zhouhai02 <[email protected]>
Date: 2017-08-06T17:31:05Z
Move 'args' field to CommandLineOptions
commit 8d8dd4d9c44b027ae1c7431e2d0b74fcd4e6d163
Author: zhouhai02 <[email protected]>
Date: 2017-08-06T19:01:02Z
cleanup the test classes in flink-clients
commit 5b7e52cb9af8200fe166d19f25deb8a89295201f
Author: zhouhai02 <[email protected]>
Date: 2017-08-06T19:20:45Z
fix checkstyle
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
