Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4484
  
    Hi @yew1eb,
    I'm afraid we should not merge this PR. While I do realise that keeping the 
code clean is good, I don't think we should just change some parts of the code 
only to make them look nicer. These changes might look small and harmless but 
they still require the attention and concentration of a committer to review and 
they might inadvertently introduce other small bugs.
    
    There also might be changes coming up for the client components, so this 
code might not be relevant in the near future anymore. 
    
    In the future, to avoid doing unnecessary work, please open a Jira and 
discuss changes before starting the actual work. This way someone with 
experience in the code base can tell you whether certain changes make sense or 
not.
    
    I'm very sorry for the inconvenience this causes you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to