ASF GitHub Bot commented on FLINK-7376:

Github user aljoscha commented on the issue:

    Hi @yew1eb,
    I'm afraid we should not merge this PR. While I do realise that keeping the 
code clean is good, I don't think we should just change some parts of the code 
only to make them look nicer. These changes might look small and harmless but 
they still require the attention and concentration of a committer to review and 
they might inadvertently introduce other small bugs.
    There also might be changes coming up for the client components, so this 
code might not be relevant in the near future anymore. 
    In the future, to avoid doing unnecessary work, please open a Jira and 
discuss changes before starting the actual work. This way someone with 
experience in the code base can tell you whether certain changes make sense or 
    I'm very sorry for the inconvenience this causes you!

> Cleanup options class and test classes in flink-clients 
> --------------------------------------------------------
>                 Key: FLINK-7376
>                 URL: https://issues.apache.org/jira/browse/FLINK-7376
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Hai Zhou
>            Priority: Critical
>              Labels: cleanup, test

This message was sent by Atlassian JIRA

Reply via email to