Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4473
Hi @tzulitai ,
Let's reach a consensus before I do any more works.
1) I didn't add all KPL's configs in this PR. I only added some
configs that I think might be useful to Flink users. The full list of KPL
configs is
[here](https://github.com/awslabs/amazon-kinesis-producer/blob/master/java/amazon-kinesis-producer-sample/default_config.properties).
I don't think exposing all KPL configs is a good idea. What do you think?
2) I absolutely agree that there'd better be a consistent way to keep
configs up-tp-date. But there probably isn't as long as Flink wraps around KPL,
because right now we have to always set KPL configs in
`FlinkKinesisProducer#open()` with `setXxxx()`
3) If Flink uses
[`KinesisProducerConfiguration#fromProperties(Properties
props)`](https://github.com/awslabs/amazon-kinesis-producer/blob/master/java/amazon-kinesis-producer/src/main/java/com/amazonaws/services/kinesis/producer/KinesisProducerConfiguration.java)
to init `KinesisProducerConfiguration`, users can always pass in the configs
as k-v string pairs. But, it requires changing all config values in
`ProducerConfigConstants`, e.g. from `aws.producer.aggregationMaxCount` to
`AggregationMaxCount`, because KPL library itself doesn't provide a util class
with key names as string. How much would the impact be to rename those config
keys?
Bowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
