Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4473
  
    @bowenli86 the third option actually strikes me as an overall good 
solution, I didn't know that was possible.
    
    I think it would make sense to deprecate the previous configuration keys in 
favor of the `fromProperties` solution. Ideally, it would be better if we can 
simply let the user freely configure the internal Kinesis client depending on 
whatever keys are available from AWS.
    
    It also shouldn't be too much of a hassle to adapt the deprecated keys such 
that if the user still used them, we simply replace them with the new renamed 
keys, and in open() always use 
`KinesisProducerConfiguration#fromProperties(Properties props)`.
    
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to