ASF GitHub Bot commented on FLINK-7381:

Github user zentol commented on a diff in the pull request:

    --- Diff: docs/setup/config.md ---
    @@ -389,6 +389,10 @@ These parameters allow for advanced tuning. The 
default values are sufficient wh
     - `jobmanager.web.access-control-allow-origin`: Enable custom access 
control parameter for allow origin header, default is `*`.
    +### Web Frontend
    --- End diff --
    I think that having some options tied to the jobmanager while others aren't 
will just cause more work down the line. Either add it the the jobmanager 
options now and move it in a follow-up, or separate the options now and rebase 
the PR on top of it.
    The "let's refactor the rest later" mentality just doesn't work for us, see 
the translation to ConfigOptions which _still isn't done_.

> Decouple WebRuntimeMonitor from ActorGateway
> --------------------------------------------
>                 Key: FLINK-7381
>                 URL: https://issues.apache.org/jira/browse/FLINK-7381
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Webfrontend
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
> The {{WebRuntimeMonitor}} has a hard wired dependency on the {{ActorGateway}} 
> in order to communicate with the {{JobManager}}. In order to make it work 
> with the {{JobMaster}} (Flip-6), we have to abstract this dependency away. I 
> propose to add a {{JobManagerGateway}} interface which can be implemented 
> using Akka for the old {{JobManager}} code. The Flip-6 {{JobMasterGateway}} 
> can then directly inherit from this interface.

This message was sent by Atlassian JIRA

Reply via email to